257m@lemmy.ml to Programming@programming.dev · 10 months agoWhat are your programming hot takes?message-squaremessage-square889fedilinkarrow-up1349arrow-down114
arrow-up1335arrow-down1message-squareWhat are your programming hot takes?257m@lemmy.ml to Programming@programming.dev · 10 months agomessage-square889fedilink
minus-squareStudioLE@programming.devlinkfedilinkarrow-up14·10 months agoMy mantra has always been to bring solutions not problems. Applying that to code reviews makes for a far more productive experience. Rather than just pointing out errors in code help the developer with prompts towards the solution. Or, if you’re too lazy to explain why something shouldn’t be done then why should another developer have to act on your criticism?
minus-squaremuddi [he/him]@hexbear.netlinkfedilinkEnglisharrow-up3·10 months agoSame , but in my experience this can backfire even worse because the other person thinks you are trying to show off as well as make them look bad. But the problem is less with you and me, and more with this type of person
My mantra has always been to bring solutions not problems. Applying that to code reviews makes for a far more productive experience.
Rather than just pointing out errors in code help the developer with prompts towards the solution.
Or, if you’re too lazy to explain why something shouldn’t be done then why should another developer have to act on your criticism?
Same , but in my experience this can backfire even worse because the other person thinks you are trying to show off as well as make them look bad. But the problem is less with you and me, and more with this type of person