• TehPers@beehaw.org
    link
    fedilink
    English
    arrow-up
    2
    ·
    6 hours ago

    Sometimes when I don’t leave comments like that, I get review comments asking what the line does. Code like ThisMethodInitsTheService() with comments like “what does this do?” in the review.

    So now I comment a lot. Apparently reading code is hard for some people, even code that tells you exactly what it does in very simple terms.

    • hex@programming.dev
      link
      fedilink
      arrow-up
      2
      ·
      6 hours ago

      Fair. I guess in this case, it’s a manner of gauging who you’re working with. I’d much rather answer a question once in a while than over-comment (since refactors often make comments worthless and they’re so easy to miss…), but if it’s a regular occurrence, yeah it would get on my nerves. Read the fuckin name of the function! Or better yet go check out what the function does!

      • nous@programming.dev
        link
        fedilink
        English
        arrow-up
        1
        ·
        edit-2
        7 minutes ago

        Worse, refactors make comments wrong. And there is nothing more annoying then having the comment conflict with the code. Which is right? Is it a bug or did someone just forget to update the comments… The latter is far more common.

        Comments that just repeat the code mean you now have two places to update and keep in sync - a pointless waste of time and confusion.