The 8Bitdo Pro+ has been great - works really well with my Steam Deck and Switch. Sounds like the Pro 2 is the superior version with hall effect sticks.
The Switch Pro controller has always been good too. And the DualSense is really neat with the haptics and adaptive triggers - expensive, but not that much more than a Pro controller surprisingly.
To be fair I’ve had the pro controller for several years and it has held up really well. Really ergonomic and the vibration’s good, plus it has gyro. Perfect for my needs on Switch. I think it was worth what I paid.