Looked into that yesterday. I can mark generated files as generated. It collapses them but doesn’t remove them from the review, which is a bit annoying. Need something like a .diffignore
Looked into that yesterday. I can mark generated files as generated. It collapses them but doesn’t remove them from the review, which is a bit annoying. Need something like a .diffignore
Thanks, I will look into if we can make use of Facades.
I see the benefit of frameworks in having a doc / “definitive answer” on how to do certain things. This should help align developers, especially if everyone is new to the language used.
Define elegant. I think in this case the first devs built elaborate structures. Maybe seen as elegant in the beginning. But it doesn’t really make sense to introduce abstractions and structures when you don’t know yet where the domain boundaries are, etc.
This might be the solution in the end if I’m not able to improve it as much as I hope.
To enable smaller PRs we need to get rid of all the generation artefacts in the PR.
You won the bet. We don’t need that architecture, at leas in my opinion. We’re a startup. We need something to iterate as fast as possible, without craping our code base. Requirements change a lot. The initial folks did a lot of big brain thinking and introduced a lot of things that might be need to be abstracted, and most of them haven’t been used to date and just add complexity.
Problem is we depend on all of them in the backend directly, except the clients. So we need to generate them locally. We have CI checking that there is no drift in generation, though.
Do you know of any tools that refactor my branch to put all files following a certain pattern into it’s own commit?