• 9 Posts
  • 1.53K Comments
Joined 2 years ago
cake
Cake day: July 7th, 2023

help-circle


















  • Good, I just partially disagree with the 5-6 comments per PR. The number of comments is usually proportional to the number of changes. 10 comments in a 300-line PR seems excessive. 20 comments for 5k lines doesn’t.

    Sure I can just shrug it and say I’m not reviewing a 10k line PR until it’s split, but that’s not very helpful either. So I just leave more comments and if they think it’s too much, I’d encourage them to open a smaller PR next time.